[ovs-dev] [PATCH 5/7] datapath: Don't check for RCU in free_buckets in table.

Ben Pfaff blp at nicira.com
Thu Dec 30 17:29:59 UTC 2010


On Wed, Dec 29, 2010 at 03:41:33PM -0800, Jesse Gross wrote:
> free_buckets() is only called in places where the lifetime of its
> container has ended: on allocation failure and on deletion after
> a grace period.  If the container can no longer be referenced then
> neither can the buckets, so it is safe to directly free them.
> sparse complains if the pointer is directly dereferenced and lockdep
> complains if the RCU functions are used without some type of lock,
> both of which are fine in this case.  This adds an explicit cast to
> avoid the complaints.
> 
> Found with lockdep.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list