[ovs-dev] [suse 2/7] xenserver: Be compatible with non-XenServer func libraries in init script.

Patrick Mullaney pm.mullaney at gmail.com
Thu Dec 30 21:43:45 UTC 2010


On Tue, 2010-12-28 at 11:01 -0800, Justin Pettit wrote:
> On Dec 15, 2010, at 11:18 AM, Ben Pfaff wrote:
> 
> > +# source function library
> > +if [ -f /etc/init.d/functions ]; then
> > +        . /etc/init.d/functions
> > +elif [ -f /etc/rc.d/init.d/functions ]; then
> > +       . /etc/rc.d/init.d/functions
> > +elif [ -f /lib/lsb/init-functions ]; then
> > +       . /lib/lsb/init-functions
> > +else
> > +       exit 0
> > +fi
> 
> 
> I would have expected this to exit with something other than 0 and possibly print a warning.

Yes, I shamelessly cut and paste this from another script without
inspection. :-) I'll clean that up - thanks for pointing it out!

> 
> Otherwise, looks good.
> 
> --Justin
> 
> 






More information about the dev mailing list