[ovs-dev] [PATCH 15/15] ovs-ofctl: Drop assignment whose value is never used.

Ben Pfaff blp at nicira.com
Wed Feb 10 19:43:43 UTC 2010


Found by Clang (http://clang-analyzer.llvm.org).
---
 utilities/ovs-ofctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 2447ba2..7f24309 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -874,7 +874,7 @@ do_add_flows(int argc UNUSED, char *argv[])
         /* Parse and send.  str_to_flow() will expand and reallocate the data
          * in 'buffer', so we can't keep pointers to across the str_to_flow()
          * call. */
-        ofm = make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
+        make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
         str_to_flow(line, &match, buffer,
                     NULL, NULL, &priority, &idle_timeout, &hard_timeout);
         ofm = buffer->data;
-- 
1.6.6.1





More information about the dev mailing list