[ovs-dev] [PATCH 15/15] ovs-ofctl: Drop assignment whose value is never used.

[Jesse Gross]

On Wed, Feb 10, 2010 at 2:30 PM, Ben Pfaff <blp at nicira.com> wrote:
>
>  @@ -874,7 +874,7 @@ do_add_flows(int argc UNUSED, char *argv[])
>         /* Parse and send.  str_to_flow() will expand and reallocate the
> data
>          * in 'buffer', so we can't keep pointers to across the
> str_to_flow()
>          * call. */
> -        ofm = make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
> +        make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
>         str_to_flow(line, &match, buffer,
>                     NULL, NULL, &priority, &idle_timeout, &hard_timeout);
>         ofm = buffer->data;
>

I think maybe it would be cleaner to just drop the second assignment
instead.  It's the same thing but seems simpler and more consistent with
what we do in other places.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100211/6dc26be8/attachment-0003.html>