[ovs-dev] [PATCH 01/16] dpif-netdev: Fix validation of VLAN PCP value in userspace datapath.

Jesse Gross jesse at nicira.com
Fri Feb 12 21:39:38 UTC 2010


On Thu, Feb 11, 2010 at 6:18 PM, Ben Pfaff <blp at nicira.com> wrote:
>
>
>  #define VLAN_VID_MASK 0x0fff
> +#define VLAN_VID_SHIFT 0
> +
>  #define VLAN_PCP_MASK 0xe000
> +#define VLAN_PCP_SHIFT 13


We should use these shift values everywhere - there is another place in the
code that still uses 13 instead of VLAN_PCP_SHIFT.  Also, for consistency it
would be nice to use VLAN_VID_SHIFT, even if it is 0.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100212/c0d2c61d/attachment-0003.html>


More information about the dev mailing list