[ovs-dev] [PATCH 4/9] vconn: Convert vconn code to modern OVS structure.

Ben Pfaff blp at nicira.com
Wed Jan 6 22:29:17 UTC 2010


On Wed, Jan 06, 2010 at 01:15:03PM -0800, Justin Pettit wrote:
> On Dec 21, 2009, at 1:15 PM, Ben Pfaff wrote:
> > -        if (class->close || class->recv || class->send || class->wait) {
> > +        if (class->close || class->recv || class->send
> > +            || class->run || class->run_wait || class->wait) {
> >             assert(class->close != NULL);
> >             assert(class->recv != NULL);
> >             assert(class->send != NULL);
> > +            assert(class->run != NULL);
> > +            assert(class->run_wait != NULL);
> 
> This is the same question as I raised previously: is it guaranteed
> that "run" and "run_wait" are defined if any of them are?  The
> comments above their description sounds as if they may be null.

Thanks again, I deleted these bad assertions here too.




More information about the dev mailing list