[ovs-dev] [PATCH 2/9] unixctl: Improve error reporting.

[Justin Pettit]

Looks good.

--Justin


On Jan 15, 2010, at 1:09 PM, Ben Pfaff wrote:

> The ovs_error() function is our standard way of reporting startup errors,
> so use it.  (It also outputs the program name at the beginning of the
> message.)
> ---
> lib/unixctl.c |   13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/unixctl.c b/lib/unixctl.c
> index 6378439..e648cc8 100644
> --- a/lib/unixctl.c
> +++ b/lib/unixctl.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2008, 2009 Nicira Networks.
> + * Copyright (c) 2008, 2009, 2010 Nicira Networks.
>  *
>  * Licensed under the Apache License, Version 2.0 (the "License");
>  * you may not use this file except in compliance with the License.
> @@ -200,22 +200,21 @@ unixctl_server_create(const char *path, struct unixctl_server **serverp)
>                                   NULL);
>     if (server->fd < 0) {
>         error = -server->fd;
> -        fprintf(stderr, "Could not initialize control socket %s (%s)\n",
> -                server->path, strerror(error));
> +        ovs_error(error, "could not initialize control socket %s",
> +                  server->path);
>         goto error;
>     }
> 
>     if (chmod(server->path, S_IRUSR | S_IWUSR) < 0) {
>         error = errno;
> -        fprintf(stderr, "Failed to chmod control socket %s (%s)\n",
> -                server->path, strerror(error));
> +        ovs_error(error, "failed to chmod control socket %s", server->path);
>         goto error;
>     }
> 
>     if (listen(server->fd, 10) < 0) {
>         error = errno;
> -        fprintf(stderr, "Failed to listen on control socket %s (%s)\n",
> -                server->path, strerror(error));
> +        ovs_error(error, "Failed to listen on control socket %s",
> +                  server->path);
>         goto error;
>     }
> 
> -- 
> 1.6.3.3
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org