[ovs-dev] [PATCH 1/8] ofproto: Add user-specifiable datapath description (OpenFlow 1.0)

Justin Pettit jpettit at nicira.com
Fri Jan 22 22:12:04 UTC 2010


On Jan 22, 2010, at 9:17 AM, Ben Pfaff wrote:

> On Fri, Jan 22, 2010 at 01:09:06AM -0800, Justin Pettit wrote:
>> In OpenFlow 1.0, a "dp_desc" character array was added to the ofp_desc_stats
>> structure that allows a human readable description of the datapath to be
>> provided.
> 
> It looks OK relative to what's there now, but I think that we have a
> memory leak since ofproto_destroy() does not free manufacturer,
> hardware, software, serial, or dp_desc.  Am I right about that?  If so,
> would you mind fixing that at the same time?


Yep.  Good catch.  I sent out a patch to fix the problem.

--Justin






More information about the dev mailing list