[ovs-dev] [PATCH 2/8] ofproto: Add support for flow cookies (OpenFlow 1.0)

[Justin Pettit]

On Jan 22, 2010, at 9:38 AM, Ben Pfaff wrote:

> It seems questionable to me to convert flow_cookie to and from network
> byte order, mostly because it seems like a waste of time.  Would it be
> better to leave it in network byte order and then when we print it out
> (if we ever do) convert it to host byte order for printing only?

Yeah, I was thinking about that last night when I was looking over the patches.  The version I push out will do that.

> It looks like adding this here potentially wastes some space: up to 32
> bits to align "flow_cookie", then up to 56 bits to align "used".  If you
> move flow_cookie above idle_timeout, then at most we lose 24 bits to
> align "used".


Seems reasonable.  I've changed it as suggested.

--Justin