[ovs-dev] [PATCH 8/8] ofproto: Set protocol version to 0x01 (OpenFlow 1.0)

Justin Pettit jpettit at nicira.com
Sat Jan 23 02:07:44 UTC 2010


On Jan 22, 2010, at 10:20 AM, Ben Pfaff wrote:

> On Fri, Jan 22, 2010 at 01:09:13AM -0800, Justin Pettit wrote:
>> Finalize OpenFlow 1.0 wire-compatibility:
>> 
>>    - Set protocol version to 0x01
>>    - Remove references to retired OFPC_MULTI_PHY_TX
>>    - Clean extraneous spaces in header file
> 
> Looks good.
> 
> The other day I noticed that openflow.h defines OFP_VLAN_NONE twice, in
> two different places.  Is that something we did in OVS by mistake, or is
> it actually like that in the OpenFlow reference implementation too?


It's that way in the reference implementation, too.  That still doesn't mean that we didn't introduce it, though.  :-)

Thank you very much for the review.  I'll push it out shortly!

--Justin






More information about the dev mailing list