[ovs-dev] [PATCH v2] Add build checks for portable OpenFlow structure padding and alignment.

Ben Pfaff blp at nicira.com
Mon Jan 25 18:47:56 UTC 2010

On Fri, Jan 22, 2010 at 01:50:44PM -0800, Justin Pettit wrote:
> This is very impressive...so impressive that I'm going to take on
> faith that all the token parsing is correct.  :-)

Oh, it's not.  It's just good enough for the headers that it needs to
parse.  Try putting, say, a quoted string in your header and watch it

> I think the convention in Python is to wrap everything in functions
> and then add an "if __name__ == '__main__'" to the bottom of the
> program that calls into those functions.  Very minor, but I think it
> makes things a bit clearer.


This makes an ugly program superficially better, I guess.

> Thanks for pulling this together so quickly.  It will be a great
> sanity-check before pushing the OpenFlow 1.0 changes.

Hey, it even *looks* like it was pulled together quickly.  (But it

I'll push this soon.

More information about the dev mailing list