[ovs-dev] [PATCH] Initial implementation of sFlow.

Ben Pfaff blp at nicira.com
Mon Jan 25 18:55:25 UTC 2010


Thank you.

I've now merged "sflow" into master and deleted the "sflow" branch.
This means that sflow support will be in the next release from "master".

On Fri, Jan 22, 2010 at 04:13:54PM -0800, Neil McKee wrote:
> We did a completely fresh checkout + build + run and all is well.
> 
> Green light,  as far as we are concerned.
> 
> Regards,
> Neil
> 
> 
> On Jan 22, 2010, at 11:13 AM, Ben Pfaff wrote:
> 
> > On Thu, Jan 21, 2010 at 04:33:09PM -0800, Neil McKee wrote:
> >> I attach another patch to the sflow branch with some very minor tweaks,  all to ofproto-sflow.c:
> > 
> > [...]
> > 
> >> Other than these,  it seems that everything else is working great.
> > 
> > Thank you, Neil!
> > 
> > I broke your patch up into three smaller commits, added the descriptions
> > that you provided with minor edits, and pushed them off to the branch.
> > 
> > If this looks good to you now, then I think it's about ready to merge.
> > Does anyone know of additional work that should be done before then?  I
> > have a to-do item on my whiteboard that the sflow module should be able
> > to determine the local IP address automatically, but I don't think
> > that's a big enough deal to defer merging.
> 
> ----
> Neil McKee
> InMon Corp.
> http://www.inmon.com
> 
> 
> 




More information about the dev mailing list