[ovs-dev] [PATCH 06/13] ovsdb-idl: Fix use-after-free error in ovsdb_idl_txn_delete().

Jesse Gross jesse at nicira.com
Mon Jan 25 22:03:51 UTC 2010


Looks good.

On Mon, Jan 25, 2010 at 1:18 PM, Ben Pfaff <blp at nicira.com> wrote:

> ---
>  lib/ovsdb-idl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
> index 4f54733..7ba0fd6 100644
> --- a/lib/ovsdb-idl.c
> +++ b/lib/ovsdb-idl.c
> @@ -1229,6 +1229,7 @@ ovsdb_idl_txn_delete(struct ovsdb_idl_row *row)
>         assert(!row->prereqs);
>         hmap_remove(&row->table->idl->txn->txn_rows, &row->txn_node);
>         free(row);
> +        return;
>     }
>     if (hmap_node_is_null(&row->txn_node)) {
>         hmap_insert(&row->table->idl->txn->txn_rows, &row->txn_node,
> --
> 1.6.3.3
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100125/1ac50704/attachment-0003.html>


More information about the dev mailing list