[ovs-dev] [PATCH 05/13] Cleanly separate IDL annotations from OVSDB schema information.

[Jesse Gross]

On Mon, Jan 25, 2010 at 1:18 PM, Ben Pfaff <blp at nicira.com> wrote:

> Until now, the OVSDB IDL annotations have been glommed together with the
> schema information in a single file, and then we've used ovsdb-idlc to
> extract the schema from that file.  This commit reverses the process:
> the schema and the annotations are stored separately and then glommed
> together as necessary at build time.
>
> This new arrangement has a few advantages:
>
>    - We can now easily have multiple different sets of IDL annotations
>      for a single OVSDB schema.  For example, some users may not need
>      access to columns that other users do.
>
>    - Bugs in ovsdb-idlc cannot screw up the underlying schema (as shown
>      by a recent commit).
>

The code looks fine but I can't say that I'm too thrilled about this.  It
seems to me that by separating the two components into different files,
the likelihood of errors actually increases since it is easier that one
might be updated without the other or other mistakes.

The first advantage is obviously true, though it seems unlikely that we will
actually use it.

As for the second advantage, wasn't the problem caused by an error in the
IDL file, not a bug in the converter?  Personally I would prefer that
ovsdb-idlc just be stricter about what it lets through.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100125/bc6a17d6/attachment-0003.html>