[ovs-dev] [PATCH 2/3] ofproto: Mark NXT_ACT_SET_CONFIG and NXT_ACT_GET_CONFIG obsolete.

Ben Pfaff blp at nicira.com
Tue Jan 26 19:43:54 UTC 2010


These Nicira-specific requests have not been implemented for some time.
In case we need them later we can always reimplement them.
---
 include/openflow/nicira-ext.h |    9 ++++-----
 ofproto/ofproto.c             |    6 ------
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
index a62f59e..41cd7ec 100644
--- a/include/openflow/nicira-ext.h
+++ b/include/openflow/nicira-ext.h
@@ -37,12 +37,11 @@ enum nicira_type {
      * pairs in the form "key=value\n". */
     NXT_STATUS_REPLY,
 
-    /* Configure an action.  Most actions do not require configuration
-     * beyond that supplied in the actual action call. */
-    NXT_ACT_SET_CONFIG,
+    /* No longer used. */
+    NXT_ACT_SET_CONFIG__OBSOLETE,
 
-    /* Get configuration of action. */
-    NXT_ACT_GET_CONFIG,
+    /* No longer used. */
+    NXT_ACT_GET_CONFIG__OBSOLETE,
 
     /* No longer used. */
     NXT_COMMAND_REQUEST__OBSOLETE,
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 59cc3e7..c4bce91 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2928,12 +2928,6 @@ handle_vendor(struct ofproto *p, struct ofconn *ofconn, void *msg)
     case NXT_STATUS_REQUEST:
         return switch_status_handle_request(p->switch_status, ofconn->rconn,
                                             msg);
-
-    case NXT_ACT_SET_CONFIG:
-        return ofp_mkerr(OFPET_BAD_REQUEST, OFPBRC_BAD_SUBTYPE); /* XXX */
-
-    case NXT_ACT_GET_CONFIG:
-        return ofp_mkerr(OFPET_BAD_REQUEST, OFPBRC_BAD_SUBTYPE); /* XXX */
     }
 
     return ofp_mkerr(OFPET_BAD_REQUEST, OFPBRC_BAD_SUBTYPE);
-- 
1.6.3.3





More information about the dev mailing list