[ovs-dev] [PATCH 2/3] datapath: Support CHECKSUM_PARTIAL on older kernels.
Ben Pfaff
blp at nicira.com
Tue Jan 26 23:01:57 UTC 2010
On Tue, Jan 26, 2010 at 05:19:37PM -0500, Jesse Gross wrote:
> On older kernels we would not correctly update partial checksums
> because it was difficult to determine the type of checksum. This
> uses some hints to infer the correct type of checksum so that it
> can be updated. It also allows us to correctly define
> CHECKSUM_PARTIAL, which is important for other components.
It's very clearly written. That's great.
I wish I understood these issues better though. They always seem
inherently confusing to me.
I guess you've done some testing?
The only issue I see is stylistic: please delete the {} that appear
around single statements, which kernel style discourages.
More information about the dev
mailing list