[ovs-dev] [PATCH 3/3] datapath: Fix compilation on newer old-style Xen kernels.
Jesse Gross
jesse at nicira.com
Tue Jan 26 23:19:22 UTC 2010
On Tue, Jan 26, 2010 at 6:09 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Jan 26, 2010 at 05:19:38PM -0500, Jesse Gross wrote:
> > Some ports of Xen (such as Debian Lenny's) use the old style
> > Xen checksumming fields on newer kernels. Normally the code that
> > deals with those fields isn't used at all on newer kernels. This
> > updates the checksumming pointer code with some changes from Lenny
> > Xen since it is cleaner and works well with our existing compatibility
> > layer.
>
> I read this fairly carefully. It looks good to me.
>
> I wasn't able to get it to apply with "git am", though, so I couldn't
> build-test it on any kernels. I hope that you tried it with various
> kernels.
>
Thanks for the review - checksum offloading is definitely pretty
complicated. I'm reasonable confident that these changes are correct though
and I did some testing on different kernels, so I pushed the set.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100126/78dede19/attachment-0003.html>
More information about the dev
mailing list