[ovs-dev] [PATCH] netdev: Correctly maintain netdev refcounts even if errors occur.
jesse at nicira.com
Fri Jan 29 18:34:35 UTC 2010
On Fri, Jan 29, 2010 at 1:21 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Jan 28, 2010 at 08:16:36PM -0500, Jesse Gross wrote:
> > If an error occured while opening a netdev it would decrement the
> > refcount, even though it was never incremented. Depending on
> > the timing this could result in either an error message or an
> > assertion failure. This workaround simply always increments
> > the refcount before openning a device. A more complete fix
> > already exists in the netdev overhaul in the 'next' branch.
> Looks good.
> I looked over the code fairly thoroughly after applying this, but I
> didn't build or run-time test it.
Thanks, I pushed it to master.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the dev