[ovs-dev] [PATCH] datapath: Don't update flow key when applying actions.

Ben Pfaff blp at nicira.com
Thu Jul 15 20:09:21 UTC 2010


On Thu, Jul 15, 2010 at 01:03:58PM -0700, Jesse Gross wrote:
> Currently the flow key is updated to match an action that is applied
> to a packet but these field are never looked at again.  Not only is
> this a waste of time it also makes optimizations involving caching
> the flow key more difficult.

We deliberately un-optimized this back in March, on the basis that "we
sometimes use the key for checks later on":

commit 11cdf5e612949b61ee0f531d355a911e0c59d6de
Author: Jesse Gross <jesse at nicira.com>
Date:   Fri Mar 12 16:36:58 2010 -0500

    datapath: Consistently maintain flow key.
    
    After executing an action that changes a packet sometimes we update
    the flow key and sometimes we don't.  This is potentially problematic
    because we sometimes use the key for checks later on.  This consistently
    maintains the key.

Are you only removing updates that we actually use?




More information about the dev mailing list