[ovs-dev] [CCC 3/3] vswitchd: Don't act as learning switch in secure mode with no controllers

Ben Pfaff blp at nicira.com
Fri Jul 16 16:14:52 UTC 2010


On Fri, Jul 16, 2010 at 12:10:25AM -0700, Justin Pettit wrote:
> Don't act as a learning switch when the fail-mode is "secure" and no
> controllers are defined.  This allows the bridge to come up in a state
> where it won't pass any traffic until a controller has told it to do so.
> 
> Note that "secure" means that it won't add a rule to do normal
> processing, but it doesn't flush any existing flows.

The parameter should be "const" here:

> +enum ofproto_fail_mode
> +ofproto_get_fail_mode(struct ofproto *p)
> +{
> +    return p->fail_mode;
> +}
> +

Otherwise looks good, thanks.




More information about the dev mailing list