[ovs-dev] [PATCH] xenserver: Kill bond slaves' dhclients when bringing up bond master.

Ben Pfaff blp at nicira.com
Fri Jul 16 16:23:44 UTC 2010


On Fri, Jul 16, 2010 at 09:14:47AM +0100, Ian Campbell wrote:
> On Thu, 2010-07-15 at 20:51 +0100, Ben Pfaff wrote:
> > This fixes the converse of the problem addressed by commit fe19e820
> > "xenserver: Kill bond master's dhclient when bringing up bond slave".  In
> > that commit's log message, I claimed that the converse was not a problem,
> > but I was wrong.  I must have screwed up in testing, because it really is
> > a problem.
> 
> I remember considering this case as well when I reviewed the earlier.
> patch. At first I thought it was a problem but then I convinced myself
> otherwise -- looks like I should trust my first instinct.
> 
> > This commit fixes it.
> 
> Looks good to me.
> 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > Reported-by: Michael Mao <mmao at nicira.com>
> 
> Acked-by: Ian Campbell <Ian.Campbell at citrix.com>

Thank you.  I added your Acked-by and pushed this to master.




More information about the dev mailing list