[ovs-dev] [QoS fixes 01/10] learning-switch: Reserved addresses are destinations, not sources.

Justin Pettit jpettit at nicira.com
Mon Jul 19 22:35:46 UTC 2010


Looks good.

--Justin


On Jul 16, 2010, at 3:52 PM, Ben Pfaff wrote:

> A switch is not supposed to forward packets directed to MAC addresses
> 01:80:c2:00:00:0x.  This code was instead dropping packets *from* those
> addresses.
> 
> (This code is only used by ovs-controller, so the bug is not a big deal.)
> ---
> lib/learning-switch.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/learning-switch.c b/lib/learning-switch.c
> index 7eb9e1c..413a70f 100644
> --- a/lib/learning-switch.c
> +++ b/lib/learning-switch.c
> @@ -410,7 +410,8 @@ process_packet_in(struct lswitch *sw, struct rconn *rconn, void *opi_)
>         }
>     }
> 
> -    if (eth_addr_is_reserved(flow.dl_src)) {
> +    /* Drop frames for reserved multicast addresses. */
> +    if (eth_addr_is_reserved(flow.dl_dst)) {
>         goto drop_it;
>     }
> 
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list