[ovs-dev] [QoS fixes 09/10] netdev-linux: Dump all queues, not just direct children of the root.

Justin Pettit jpettit at nicira.com
Tue Jul 20 01:58:55 UTC 2010


Looks good.

--Justin


On Jul 16, 2010, at 3:52 PM, Ben Pfaff wrote:

> A netdev-linux traffic control implementation has to dump all of a port's
> traffic classes in a couple of different situations.  start_queue_dump()
> is supposed to do that.  But it was specifying TC_H_ROOT as tcm_parent,
> which only dumped classes that were direct children of the root.  This
> commit changes tcm_parent to 0, which obtains all traffic classes
> regardless of parent.
> ---
> lib/netdev-linux.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 8cd40cd..bcba1a2 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linux.c
> @@ -1625,7 +1625,7 @@ start_queue_dump(const struct netdev *netdev, struct nl_dump *dump)
>     struct tcmsg *tcmsg;
> 
>     tcmsg = tc_make_request(netdev, RTM_GETTCLASS, 0, &request);
> -    tcmsg->tcm_parent = TC_H_ROOT;
> +    tcmsg->tcm_parent = 0;
>     nl_dump_start(dump, rtnl_sock, &request);
>     ofpbuf_uninit(&request);
> }
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list