[ovs-dev] [vlog v2 2/7] timeval: Make timeval module initialize itself when necessary.

Jesse Gross jesse at nicira.com
Wed Jul 21 21:37:34 UTC 2010


On Fri, Jul 16, 2010 at 12:00 PM, Ben Pfaff <blp at nicira.com> wrote:
>
> -/* Initializes the timetracking module. */
> +/* Initializes the timetracking module.
> + *
> + * It is not necessary to call this function directly, because other time
> + * functions will call it automatically, but it doesn't hurt. */
>  void
>  time_init(void)
>

Is there any reason to explicitly initialize the time module?  If not,
should we just remove the callers of it, like you did for vlog_init(), and
make it static?


> -    inited = true;
>     time_refresh();
>

I don't think that we want to call time_refresh() here if we are statically
setting wall_tick and monotonic_tick to true.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100721/6200e849/attachment-0003.html>


More information about the dev mailing list