[ovs-dev] [loops 3/6] datapath: Change vport_send() to return negative error values.

[Jesse Gross]

On Fri, Jul 23, 2010 at 4:44 PM, Ben Pfaff <blp at nicira.com> wrote:
>
> @@ -1262,19 +1264,20 @@ int vport_send(struct vport *vport, struct sk_buff
> *skb)
>                if (net_ratelimit())
>                        printk(KERN_WARNING "%s: dropped over-mtu packet: %d
> > %d\n",
>                               dp_name(vport_get_dp_port(vport)->dp),
> packet_length(skb), mtu);
> +               retval = 0;


Is it worth returning an actual error code here?  We don't really need it
for anything but if we are reporting status we might as well make it as
useful as possible.  Maybe -E2BIG?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100726/7b7880d0/attachment-0003.html>