[ovs-dev] [PATCH 1/3] ofp-parse: Break string-to-openflow parsing into library functions

[Justin Pettit]

On Jul 29, 2010, at 10:19 AM, Ben Pfaff wrote:

> One possible nit is that I've been trying to avoid "ofp_" prefixes in
> new code on stuff not actually provided by OpenFlow; I'm trying to
> regard that prefix as reserved by them.  So if you can think of another
> name for ofp_str_to_flow(), then I'd like that.

Okay.  I renamed it parse_ofp_str().

> There's trailing white space on a few lines in ofp-parse.c and
> ofp-parse.h.  Can you remove it, please?

Yep.

> I would apply the following, to remove unnecessary #includes and keep
> the remaining #includes in the order recommended by CodingStyle:


Done.  Thanks for the review!

--Justin