[ovs-dev] [PATCH] datapath: Remove redundant checks on SKBs.

Ben Pfaff blp at nicira.com
Fri Jul 30 16:35:08 UTC 2010


On Thu, Jul 29, 2010 at 07:27:33PM -0700, Jesse Gross wrote:
> On vport ingress we already check for shared SKBs but then later
> warn in several other places.  In a similar vein, we check every
> packet to see if it is LRO but only certain vports can produce
> these packets.  Remove and consolidate checks to the places where
> they are needed.

The "share" checks, anyway, were in all those places to catch it when I
do something stupid with skbs internally in the datapath.  I guess I
understand skbuffs better than I did when I inserted those, so it seems
like it's OK to delete them now.




More information about the dev mailing list