[ovs-dev] [PATCH 2/3] vport: Make dp_port->vport always valid.

Ben Pfaff blp at nicira.com
Fri Jul 30 16:44:00 UTC 2010


On Thu, Jul 29, 2010 at 05:38:54PM -0700, Jesse Gross wrote:
> When we detached a vport we would assign NULL to dp_port->vport
> before calling synchronize_rcu().  However, since vports have a
> longer lifetime than dp_ports there were no checks before
> dereferencing dp_port->vport.  This changes the behavior to
> match the assumption by not assigning NULL during detach.

Looks good.  This fixes a bug, right?  It's good to make that clear in
the commit message.




More information about the dev mailing list