[ovs-dev] [PATCH] ovs-ofctl: Add support for OpenFlow enqueue action.

[Ben Pfaff]

On Fri, Jul 30, 2010 at 03:37:02PM -0700, Jesse Gross wrote:
> On Fri, Jul 30, 2010 at 10:40 AM, Ben Pfaff <blp at nicira.com> wrote:
> >
> > +        } else if (!strcasecmp(act, "enqueue")) {
> > +            char *sp = NULL;
> > +            char *port = strtok_r(arg, ":q", &sp);
> >
> 
> Shouldn't the delimiter be just ":"?

I thought I would also allow 'q' since that's the delimiter that
ofp-print uses for printing enqueue actions.  Or I could change
ofp-print just to use ':'.  What do you prefer?

> +.IP \fBoutput\fR:\fIport\fB:\fIqueue\fR
> > +Enqueues the packet on the specified \fIqueue\fR within port
> > +\fIport\fR.  The number of supported queues depends on the switch;
> > +some OpenFlow implementations do not support queuing at all.
> 
>  The command here should be "enqueue" not "output".

Oops.  Cut and paste strikes again.

Thanks,

Ben.