[ovs-dev] [PATCH] ovs-ofctl: Add support for OpenFlow enqueue action.

[Jesse Gross]

On Fri, Jul 30, 2010 at 3:40 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, Jul 30, 2010 at 03:37:02PM -0700, Jesse Gross wrote:
> > On Fri, Jul 30, 2010 at 10:40 AM, Ben Pfaff <blp at nicira.com> wrote:
> > >
> > > +        } else if (!strcasecmp(act, "enqueue")) {
> > > +            char *sp = NULL;
> > > +            char *port = strtok_r(arg, ":q", &sp);
> > >
> >
> > Shouldn't the delimiter be just ":"?
>
> I thought I would also allow 'q' since that's the delimiter that
> ofp-print uses for printing enqueue actions.  Or I could change
> ofp-print just to use ':'.  What do you prefer?


The 'q' is fine, I just wasn't expecting it since it is left undocumented
(which is also fine).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100730/50121591/attachment-0003.html>