[ovs-dev] [PATCH 3/3] netdev: Remove may_create/may_open flags.

Jesse Gross jesse at nicira.com
Wed Jun 2 01:17:15 UTC 2010


On Tue, Jun 1, 2010 at 4:34 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Jun 01, 2010 at 04:17:40PM -0700, Jesse Gross wrote:
> > The most recent revision of the netdev library added may_create
> > and may_open flags to explicitly state the intent of the caller as
> > to whether the device should already be in use.  This was simply
> > a sanity check for users of the netdev library and the configuration.
> > At this point the netdev library and its users are well behaved and
> > should no longer need to be checked.  Additional checks have also
> > been added for incorrect configuration that mean the netdev library
> > is no longer the primary line of defense.
>
> I never really understood exactly what was going on here.  I'm happy to
> take your word for it that it is no longer necessary.
>

All of this was a response to some hard to track down bugs that we were
having with a previous implementation of the netdev library.


>
> I'd prefer to retain the memset() in netdev_open_default(), if you don't
> mind, to avoid surprising behavior should netdev_options change.
>

OK, that's fine.

I pushed the updated set out.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100601/1a7520ef/attachment-0003.html>


More information about the dev mailing list