[ovs-dev] [PATCH] datapath: Fix mutual exclusion with bridge module.

Ben Pfaff blp at nicira.com
Wed Jun 2 22:46:29 UTC 2010


On Wed, Jun 02, 2010 at 02:46:00PM -0700, Jesse Gross wrote:
> On Wed, Jun 2, 2010 at 12:52 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Mutual exclusion with the Linux bridge module has always been a problem.
> > But I think that this new approach should work reliably.  It is also
> > simpler.
> 
>  I don't really like this in principle because it makes the netdev vport
> more special than it needs to be.  Currently it is possible to turn off a
> flag that marks netdevs as required for module loading and you can run even
> if the bridge is loaded, using, say, purely GRE ports.  This is analogous to
> having a GRE protocol handler already registered but still being able run
> using physical devices.
> 
> However, in practice using Linux devices is important and the consequences
> of loading at the same time as the bridge are bad.  This is clearly a
> significant improvement, so I guess it is fine, especially if we won't need
> it in the future.

Thanks for the review.

I don't think it's very likely in practice that anyone would want to
work exclusively with GRE vports.  If it comes up, we can worry about it
then.

You really don't want to see the patch I was preparing before I came up
with this solution.  I found a couple more ways to do mutual exclusion,
but they only worked with specific Linux configuration options, so it
added another couple of layers of #ifdefs.

I pushed this out.




More information about the dev mailing list