[ovs-dev] [PATCH 2/3] xenserver: Ditch ovs-xenserverd even on XenServer 5.5.0.

Ian Campbell Ian.Campbell at citrix.com
Tue Jun 8 08:46:16 UTC 2010


On Mon, 2010-06-07 at 22:34 +0100, Jesse Gross wrote:
> On Fri, Jun 4, 2010 at 12:47 PM, Ben Pfaff <blp at nicira.com> wrote:
>         +# On XenServer 5.5.0, we need refresh-network-uuids to run
>         whenever
>         +# XAPI starts or restarts.  (On XenServer 5.6.0, XAPI calls
>         the
>         +# "update" method of the vswitch-cfg-update plugin whenever
>         it starts
>         +# or restarts, so this is no longer necessary.)
>         +if test "$PRODUCT_VERSION" = "5.5.0"; then
>         +    RNU=/usr/share/openvswitch/scripts/refresh-network-uuids
>         +    XSS=/opt/xensource/libexec/xapi-startup-script
>         +    rm -f $XSS
>         +    ln -s $RNU $XSS
>         +fi
> 
> 
> I feel like we should at least warn if there is something there,
> rather than just blowing it away.

I think the chance of a clash is microscopic but I would prefer to abort
if one is detected, just in case. In the 0.01% likely case we do find a
clash in the field I think moving both the vswitch script and the
clashing script to a .d directory and replacing with a script to process
the .d directory would work but I wouldn't suggest bothering with this
until a concrete clash shows up.

> Otherwise looks good as long as you are confident that it is OK to use
> this hook.

We think it is OK, it was added to support "per-host upgrade actions"
but was never actually used for this as far as we can tell. We don't
test it but since this usage is limited to 5.5 only I don't think that
is a problem.

Ian.





More information about the dev mailing list