[ovs-dev] [PATCH] xenserver: Don't start OVS if network.conf isn't "openvswitch"

Ian Campbell Ian.Campbell at eu.citrix.com
Tue Jun 8 19:58:25 UTC 2010


On Tue, 2010-06-08 at 20:57 +0100, Justin Pettit wrote:
> On Jun 8, 2010, at 12:45 PM, Ian Campbell wrote:
> 
> > On Tue, 2010-06-08 at 18:38 +0100, Justin Pettit wrote:
> > 
> >> +    *)
> >> +        echo "Open vSwitch disabled (/etc/xensource/network.conf is not 'openvswitch')" >&2
> >> +        exit 0
> >> +        ;;
> >> +esac
> > 
> > Could we drop the echo and just exit silently if the system is
> > configured in some other mode? This would enable me to unconditionally
> > enable the vswitch initscript without odd messages appearing in the
> > bridging case.
> 
> I pushed a change that makes a value of "bridge" just silently exit.
> An invalid value still complains.  Does that seem reasonable?

Exceedingly. Thanks!

Ian.






More information about the dev mailing list