[ovs-dev] [PATCH 5/6] netdev-linux: Add capability to get stats from vport layer.

Jesse Gross jesse at nicira.com
Thu Jun 10 20:19:04 UTC 2010


On Thu, Jun 10, 2010 at 10:05 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Jun 09, 2010 at 07:33:20PM -0700, Jesse Gross wrote:
> > The vport layer has the ability to track stats using 64-bit counters,
> > even if the kernel is only 32-bit.  This first attempts to collect
> > stats from these counters if they are available and otherwise falls
> > back to the normal Linux interfaces.
>
> This adds a VALID_VPORT_STATS bit, but I didn't understand why at first,
> because it doesn't make sense to cache stats.  But it looks like
> VALID_VPORT_STATS just keeps track of whether have_vport_stats is valid.
> I'd appreciate a comment on VALID_VPORT_STATS that mentions that.  Or
> you could rename it to VALID_HAVE_VPORT_STATS.
>

You're right, VALID_HAVE_VPORT_STATS is clearer, so I changed it to that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100610/96df4130/attachment-0003.html>


More information about the dev mailing list