[ovs-dev] [gmane.linux.network] [PATCHv3 1/2] net: Enable 64-bit net device statistics on 32-bit architectures

[Jesse Gross]

On Mon, Jun 14, 2010 at 5:05 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Mon, Jun 14, 2010 at 04:46:37PM -0700, Jesse Gross wrote:
> > On Sun, Jun 13, 2010 at 4:08 PM, Ben Pfaff <blp at nicira.com> wrote:
> >
> > > Upstream Linux is moving toward enabling 64-bit device statistics
> > > even on 32-bit architectures.  Here's the first patch, which
> > > David Miller has already applied to next-next (which will be
> > > merged into the next upstream Linux).
> >
> >  This will obviously be an improvement, though the number of ways that we
> > collect stats seems to be mushrooming especially since this has to be
> > enabled in each driver.
>
> I don't think that it will cause much of an actual change, though.
> These 64-bit stats are still delivered through the same Netlink messages
> as before, just as another attribute.
>

Yeah, they are.  It just depends on how we want to use them and how
complicated we want to make things.  In an ideal world, we always want
64-bit stats and if possible should use the native Linux stats (as opposed
to the vport stats that I just added).  It isn't necessarily obvious what
the best mechanism to use is (on kernels that support this, IFLA_STATS64
will exist in the Netlink message but will be 32-bit if the driver doesn't
supply 64-bit stats).  It's not that complicated and we don't have to fully
optimize for all cases, I was just commenting that the number of special
cases for getting stats is growing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100614/f6e767e6/attachment-0003.html>