[ovs-dev] [PATCH 2/2] vlog: Check that all declared vlog modules are used, at "make dist" time.
Ben Pfaff
blp at nicira.com
Tue Jun 15 17:26:11 UTC 2010
On Mon, Jun 14, 2010 at 05:10:05PM -0700, Jesse Gross wrote:
> On Mon, Jun 14, 2010 at 4:17 PM, Ben Pfaff <blp at nicira.com> wrote:
>
> > On Mon, Jun 14, 2010 at 01:24:09PM -0700, Jesse Gross wrote:
> > > One thought that did come to mind is whether this hook is really best
> > suited
> > > as a dist hook, as it doesn't really have anything to do with
> > distribution.
> > > It doesn't really matter though, since the presence of extra vlog
> > modules
> > > doesn't hurt anything and "make dist" should be run often enough for
> > > somebody to notice.
> >
> > We *could* hang it off of the "all" target (using "all-local" instead of
> > "dist-hook"). Then we'd get it checked on every "make". Does that
> > sound reasonable?
>
> Sure, that sounds good.
OK, I'm testing that change and I'll push it when it's ready. Thank you.
More information about the dev
mailing list