[ovs-dev] [PATCH 1/3] datapath: Call vswitch_skb_checksum_setup() before doing GSO.

Ben Pfaff blp at nicira.com
Thu Jun 17 23:29:58 UTC 2010


On Thu, Jun 17, 2010 at 04:27:29PM -0700, Jesse Gross wrote:
> Since GSO computes checksums as it does segmentation, we need to
> setup the checksum pointers before calling skb_gso_segment().  Failing
> to do so can potentially result in warnings, incorrect checksums,
> crashes, or redundant checksum computation.  In general we don't
> hit this case because the code path is run during the first packet
> in a flow, which is generally not a large GSO packet.
> 
> This was found during the investigation of NIC-121 but has no impact
> on it because vswitch_skb_checksum_setup() is a no-op on 2.6.27-based
> XenServer kernels.

Good catch, Jesse.  Looks good.




More information about the dev mailing list