[ovs-dev] [PATCH 2/3] gre: Check vswitch_skb_checksum_setup() return code.

Ben Pfaff blp at nicira.com
Thu Jun 17 23:32:27 UTC 2010


On Thu, Jun 17, 2010 at 04:27:30PM -0700, Jesse Gross wrote:
> If vswitch_skb_checksum_setup() returns an error, the checksum
> pointers probably haven't been set correctly which could cause
> a crash later.  We should give up immediately on error.

Looks good.

vswitch_skb_checksum_setup() is also called from modify_vlan_tci()
without an error check.  I guess we should make the same change there?




More information about the dev mailing list