[ovs-dev] [Simple DB Stats 03/11] ovsdb-idl: Simplify usage of ovsdb_idl_run().

Justin Pettit jpettit at nicira.com
Tue Jun 22 22:08:45 UTC 2010


On Jun 10, 2010, at 5:14 PM, Ben Pfaff wrote:

> It makes client code simpler if ovsdb_idl_run() simply lets the caller
> know whether anything changed.
> ---
> 
> diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
> index 94dd466..83124dc 100644
> --- a/lib/ovsdb-idl.c
> +++ b/lib/ovsdb-idl.c
> @@ -231,9 +231,10 @@ ovsdb_idl_clear(struct ovsdb_idl *idl)
>     }
> }
> 
> -void
> +bool
> ovsdb_idl_run(struct ovsdb_idl *idl)
> {

It may be nice to document what this return value means.  Otherwise, looks good.

--Justin






More information about the dev mailing list