[ovs-dev] [Simple DB Stats 07/11] ovs-vswitchd: Allow bridge code to manage the database connection itself.

Justin Pettit jpettit at nicira.com
Tue Jun 22 22:54:04 UTC 2010


On Jun 10, 2010, at 5:14 PM, Ben Pfaff wrote:

> +            ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
> +            ovsdb_idl_txn_commit(txn);
> +            ovsdb_idl_txn_destroy(txn); /* XXX */

What's the reason for the "XXX"?  I know that it existed in the previous code, but it's not exactly confidence inspiring.  :-)

Otherwise, seems fine.

--Justin






More information about the dev mailing list