[ovs-dev] [Simple DB Stats 09/11] bridge: Implement basic periodic update of interface statistics.

Justin Pettit jpettit at nicira.com
Wed Jun 23 01:14:32 UTC 2010


On Jun 10, 2010, at 5:14 PM, Ben Pfaff wrote:

> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index 345744e..48a7f31 100644
> --- a/vswitchd/vswitch.xml
> +++ b/vswitchd/vswitch.xml
> @@ -503,6 +503,54 @@
> 
> +          Key-value pairs that report interface statistics.  The current
> +          implementation updates these counters periodically.  In the future,
> +          we plan to, instead, update them when a interface is created, when

"an interface".

> +            Number of transmit errors.  This is a super-set of transmit
> +            errors.</dd>

I understand what you're saying, but it reads a bit funny that its the number of transmit errors and a super-set of transmit errors.  Perhaps we should give examples, such as "collisions".

Otherwise, looks good.

--Justin






More information about the dev mailing list