[ovs-dev] [PATCH] vswitchd: Add entity-relationship diagram to ovs-vswitchd.conf.db.5.
blp at nicira.com
Thu Jun 24 20:04:53 UTC 2010
On Wed, Jun 23, 2010 at 12:51:08PM -0700, Jesse Gross wrote:
> On Wed, Jun 23, 2010 at 9:43 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Jun 22, 2010 at 06:45:06PM -0700, Jesse Gross wrote:
> > > Are we trying to autogenerate this file?
> > The idea is to distribute a copy of it so that everyone can enjoy the
> > helpful diagram, even those users who don't have graphviz installed.
> > Most users won't change the schema, so this works fine. If you change
> > the schema, you need graphviz if you want to get the updates. And in
> > fact most changes to the schema probably won't change the diagram anyway
> > (only changes that add or remove columns with references or add or
> > remove tables will change the diagram).
> > That's close to how we handle other files that depend on tools that
> > users might not have, e.g. vswitchd/vswitch-idl.c depends on Python that
> > some users might not have (such as users who build inside the Xen DDK).
> > (Most of those, though, we don't check into the Git repository.)
> > Anyway, thank you for your comments. Here is an incremental diff
> > against the previous version. What do you think now?
> Looks good, thanks for the explanation.
Thanks for the review.
I'm running this through a bit of testing, to make sure that I don't
break the build, then I'll push it out.
More information about the dev