[ovs-dev] [PATCH] Add default pidfile for ovsdb-server and vswitchd

[Yu Zhiguo]

Hi Ben,

Ben Pfaff wrote:
> On Mon, Jun 28, 2010 at 05:20:35PM +0800, Yu Zhiguo wrote:
>> Add default pidfile for ovsdb-server and vswitchd
>> according to manual.
> 
> I don't see a need for this.  If you want a pidfile, just pass
> "--pidfile".
> 
> But when you say "according to manual" it sounds like OVS documents that
> it creates a pidfile by default.  But we don't document it that way, at
> least not intentionally.  Is there something confusing in the manual?
> 
> 

When I use 'ovs-appctl',
# ovs-appctl ***
ovs-appctl: cannot read pidfile "/usr/local/var/run/openvswitch/ovs-vswitchd.pid" (No such file or directory)

It will look up 'ovs-vswitchd.pid'.
*I know '-t' can be used but I think it is optional.

And, please refer to manpage of 'ovs-vswitchd':
--pidfile[=pidfile]
       Causes a file (by default, ovs-vswitchd.pid) to be created indicating the PID of the running process.  If pidfile is not speci-
       fied, or if it does not begin with /, then it is created in /usr/local/var/run/openvswitch.


So I think we should create this pidfile.


-- 
Regards
Yu Zhiguo