[ovs-dev] [PATCH 2/2] xenserver: Support network names with spaces
Ben Pfaff
blp at nicira.com
Tue Mar 2 20:23:42 UTC 2010
On Tue, Mar 02, 2010 at 05:41:15PM +0000, Ian Campbell wrote:
> On Tue, 2010-03-02 at 17:09 +0000, Justin Pettit wrote:
> > On Mar 2, 2010, at 5:50 AM, Ian Campbell wrote:
>
> > > What about adding an option to ovs-vsctl which takes a xenstore root and
> > > pulls the extra keys out itself? Since ovs-vsctl is in a "proper"
> > > language(*) it ought to be trivial to get the quoting correct. Something
> > > like "set interface vif${DOMID}.${DEVID} xs-keys=${PRIVATE}".
> > >
> > > It's a bit skanky to build the XS specific knowledge into ovs-vsctl
> > > though. At the risk of complete over engineering things what about
> > > allowing ovs-vsctl to call out to one or more hooks to provide this sort
> > > of additional data for various commands?
> >
> > I'll see how things are looking today. If we have time, we'll try to
> > come up with a more permanent solution than my original patch that
> > makes us all happy.
>
> If we get rid of the building the command line in a variable thing
> (which seems unnecessary anyway) I think it's trivial to quote
> correctly, like the untested patch below.
After some discussion here, we decided that it's better to get rid of
the need for the network name on the part of the software that wanted
it. Ian, I pushed out your patch from last week along with my followups
that restore XS 5.5.0 compatibility and get rid of the dump-vif-details
script.
Patch 2/2 from this series no longer applies. Patch 1/2 still makes
sense (and it looks good to me, Justin).
More information about the dev
mailing list