[ovs-dev] [PATCH] xenserver: Various fixes for vif script

Ben Pfaff blp at nicira.com
Wed Mar 3 00:34:10 UTC 2010


It was awfully sunny for midnight on Tue, Mar 02, 2010 at
12:17:40AM -0800 when Justin Pettit wrote:

> diff --git a/xenserver/etc_xensource_scripts_vif b/xenserver/etc_xensource_scripts_vif
> index c81358a..f2fd632 100755
> --- a/xenserver/etc_xensource_scripts_vif
> +++ b/xenserver/etc_xensource_scripts_vif
> @@ -120,7 +120,7 @@ xs550_set_internal_network_uuid()
>          local net_uuid=$(xenstore-read "${PRIVATE}/network-uuid" 2>/dev/null)
>          if [ -n "${net_uuid}" ] ; then
>              logger -t scripts-vif "${bridge} xs-network-uuids ${net_uuid}"
> -            echo "-- br-set-external-id \"$bridge\" xs-network-uuids \"${net_uuid}\""
> +            echo "-- br-set-external-id $bridge xs-network-uuids \"${net_uuid}\""
>          fi

The problem was, I guess, that word-splitting in the caller didn't
eliminate the quotes around $bridge, so that ovs-vsctl got essentially
        -- br-set-external-id '"$bridge"' blah...
as arguments?

Makes sense.  But then I think we need to get rid of the quotes around
${net_uuid} for the same reason.

The rest looks good.

Thanks,

Ben.




More information about the dev mailing list