[ovs-dev] [PATCH] xenserver: Various fixes for vif script

Justin Pettit jpettit at nicira.com
Wed Mar 3 01:15:14 UTC 2010


On Mar 2, 2010, at 4:34 PM, Ben Pfaff wrote:

> It was awfully sunny for midnight on Tue, Mar 02, 2010 at
> 12:17:40AM -0800 when Justin Pettit wrote:
> 
>> diff --git a/xenserver/etc_xensource_scripts_vif b/xenserver/etc_xensource_scripts_vif
>> index c81358a..f2fd632 100755
>> --- a/xenserver/etc_xensource_scripts_vif
>> +++ b/xenserver/etc_xensource_scripts_vif
>> @@ -120,7 +120,7 @@ xs550_set_internal_network_uuid()
>>         local net_uuid=$(xenstore-read "${PRIVATE}/network-uuid" 2>/dev/null)
>>         if [ -n "${net_uuid}" ] ; then
>>             logger -t scripts-vif "${bridge} xs-network-uuids ${net_uuid}"
>> -            echo "-- br-set-external-id \"$bridge\" xs-network-uuids \"${net_uuid}\""
>> +            echo "-- br-set-external-id $bridge xs-network-uuids \"${net_uuid}\""
>>         fi
> 
> The problem was, I guess, that word-splitting in the caller didn't
> eliminate the quotes around $bridge, so that ovs-vsctl got essentially
>        -- br-set-external-id '"$bridge"' blah...
> as arguments?

Yes, exactly.

> Makes sense.  But then I think we need to get rid of the quotes around
> ${net_uuid} for the same reason.

Good point.  I've fixed that, as well.

> The rest looks good.

Thanks for the review!  I went ahead and pushed.

--Justin






More information about the dev mailing list