[ovs-dev] [PATCH 2/2] brcompatd: Make bridge ioctls synchronous again.
Justin Pettit
jpettit at nicira.com
Wed Mar 3 22:03:40 UTC 2010
On Mar 3, 2010, at 1:19 PM, Ben Pfaff wrote:
> + do {
> + retval = (add ? add_bridge : del_bridge)(idl, ovs, br_name);
> + VLOG_INFO("%sbr %s: %s",
> + add ? "add" : "del", br_name, strerror(retval));
Do we want to use the rate limit version of this function?
>
> + do {
> + struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
> + if (add) {
> + add_port(ovs, br, port_name);
> + } else {
> + del_port(br, port_name);
> + }
> + error = commit_txn(txn, true);
> + VLOG_INFO("%s %s %s: %s",
> + cmd_name, br_name, port_name, strerror(error));
Same here. It seems like we could get into a tight loop logging.
Otherwise, this all looks good to me.
--Justin
More information about the dev
mailing list