[ovs-dev] [PATCH 2/2] brcompatd: Make bridge ioctls synchronous again.

Ben Pfaff blp at nicira.com
Wed Mar 3 22:19:04 UTC 2010


On Wed, Mar 03, 2010 at 02:03:40PM -0800, Justin Pettit wrote:
> On Mar 3, 2010, at 1:19 PM, Ben Pfaff wrote:
> 
> > +        do {
> > +            retval = (add ? add_bridge : del_bridge)(idl, ovs, br_name);
> > +            VLOG_INFO("%sbr %s: %s",
> > +                      add ? "add" : "del", br_name, strerror(retval));
> 
> Do we want to use the rate limit version of this function?

That's reasonable, here and in that other spot.

> Same here.  It seems like we could get into a tight loop logging.

Well, if we get into a tight loop at all here, it's a bug.  I don't
expect it to happen.  Anyway, it can't hurt to rate-limit the log
messages, so I'll do that.




More information about the dev mailing list