[ovs-dev] openflow-1.0 : handling of max_len = 0
Jean Tourrilhes
jt at hpl.hp.com
Thu Mar 4 19:04:13 UTC 2010
Tetsuo NAKAGAWA :
>
> Hi.
>
> I'm using Open vSwitch with openflow-1.0 branch.
>
> A 'max_len' in struct ofp_action_output is explained as
> follows in "OpenFlow Specification Version 1.0.0".
>
> But ovs-vswitchd (openflow-1.0 branch) send entire message
> when max_len is 0.
Hi,
I'm sorry if you feel I'm picking on you, but I feel that
everybody is wasting time by not using the OpenFlow test suite.
The kind of problem you are reporting here is an excellent
candidates for the OpenFlow test suite, part of the reference
implementation.
But, wait a second, the test suite already test for that and
this precise problem was flagged when I ran the test suite against OVS
more than a month ago. In other words, the test suite is already
testing for that, and it was trivial for Nicira to test it.
Note that the previous patch you sent for OpenFlow 1.0
support, called "openflow-1.0 : enum ofp_config_flags isn't based upon
OpenFlow 1.0", was also an excellent candidate for the test suite.
And guess what, the test suite already testing for that and
the test was failing when I ran the test suite against OVS end of
january. And I also verified that your patch makes the test pass.
In addition, when I ran the test suite against OVS, it
identified quite a few more issues in basic OpenFlow 1.0
support. A few of them have been solved (ToS, nw_dst/nw_src), but
a few remain unfixed to date.
So, if you want to verify basic OpenFlow support in Open
vSwitch in the future, I would urge you to use the OpenFlow reference
test suite and to contribute to it. By using the test suite you will
save yourself time, and by contributing new tests to the test suite
you will make sure that subsequent versiond of Open vSwitch are tested
against it.
I think it make sense to poll our testing resources rather
than duplicating effort. As the OpenFlow test suite is the only test
suite publically available, it make sense to standardize on it and
improve it.
Regards,
Jean
More information about the dev
mailing list